BDMS-81 fix: correct GCS_SERVICE_ACCOUNT_KEY echo syntax and update relationship in Thing model#104
Closed
jirhiker wants to merge 1 commit into
Closed
BDMS-81 fix: correct GCS_SERVICE_ACCOUNT_KEY echo syntax and update relationship in Thing model#104jirhiker wants to merge 1 commit into
jirhiker wants to merge 1 commit into
Conversation
…hip in Thing model
jirhiker
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests.
|
| echo " CLOUD_SQL_USER: \"${{ secrets.CLOUD_SQL_USER }}\"" >> app.yaml | ||
| echo " CLOUD_SQL_PASSWORD: \"${{ secrets.CLOUD_SQL_PASSWORD }}\"" >> app.yaml | ||
| echo " GCS_SERVICE_ACCOUNT_KEY: \"${{ secrets.GCS_SERVICE_ACCOUNT_KEY}}\"" >> app.yaml | ||
| echo " GCS_SERVICE_ACCOUNT_KEY: ${{ secrets.GCS_SERVICE_ACCOUNT_KEY }} >> app.yaml |
Contributor
There was a problem hiding this comment.
Closing quotes should be present at the end of the line that is being echoed and then redirected to app.yaml
Member
Author
There was a problem hiding this comment.
I suspect this is part of the problem. Since the service key is JSON that uses double quotes
Contributor
There was a problem hiding this comment.
For echo to work I think that the full string needs to be in double quotes, but the escaped quotes in the inner bit should be removed if they're causing issues
echo " GCS_SERVICE_ACCOUNT_KEY: ${{ secrets.GCS_SERVICE_ACCOUNT_KEY }}" >> app.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
How
Implementation summary - the following was changed / added / removed:
Notes
Any special considerations, workarounds, or follow-up work to note?